Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable holding enter to send #98

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Disable holding enter to send #98

merged 3 commits into from
Mar 19, 2019

Conversation

bchrobot
Copy link
Member

@bchrobot bchrobot commented Mar 18, 2019 •
edited
Loading

Intercept enter key at the underlying DOM <textarea> leaf. Prevent handling of down, unless it's combined with <shift>. Submit form on up to prevent spamming by holding.

bchrobot added 3 commits March 18, 2019 13:53
@bchrobot
Fix <enter> key handling.
2604847 
Intercept enter key at the underlying DOM <textarea> leaf. Prevent handling of <enter> down, unless it's combined with <shift>. Submit form on <enter> up to prevent spamming by holding.
@bchrobot
Add method comment.
e5d0b09
@bchrobot
Handle <enter> at document level.
c0c58d2
@bchrobot bchrobot requested a review from ben-pr-p March 18, 2019 18:03
@ben-pr-p ben-pr-p merged commit e757000 into politics-rewired/deploy Mar 19, 2019
@bchrobot bchrobot deleted the politics-rewired/disable-hold-enter branch March 19, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-pr-p ben-pr-p ben-pr-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bchrobot @ben-pr-p